Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore dropping handler or unmounting #604

Merged
merged 1 commit into from
May 13, 2019
Merged

Conversation

osdnk
Copy link
Contributor

@osdnk osdnk commented May 13, 2019

https://github.com/kmagiera/react-native-gesture-handler/pull/406/files#diff-88fa64c878efe14d137f130ddbe000a5R185
From unknown reason, it has been changed here.

Probably it's just a mistake, but it was leading to memory leaks.

Copy link
Contributor

@jkadamczyk jkadamczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆒

@osdnk osdnk merged commit 2f45289 into master May 13, 2019
@osdnk osdnk deleted the restore-dropping-handler branch May 13, 2019 13:18
janicduplessis pushed a commit to janicduplessis/react-native-gesture-handler that referenced this pull request Feb 16, 2020
software-mansion/pull/406/files#diff-88fa64c878efe14d137f130ddbe000a5R185
From unknown reason, it has been changed here.

Probably it's just a mistake, but it was leading to memory leaks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants