Implement mDNS discovery and use as default #51
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the Hue Bridge developer documentation, the mDNS method is listed first, and mentioned to have replaced the old UPnP approach.
https://developers.meethue.com/develop/application-design-guidance/hue-bridge-discovery/
I implemented it using Ruby’s stdlib mDNS resolver. Since it got added in version 2.1.0, I bumped the minimum version to that one.
I think this method is preferable as a default, because it does not need internet connectivity to discover Hue bridges on a local network, and is not subject to rate limiting or temporary or permanent outage of the online API.
The old method is still available as a fallback after a 10 seconds timeout, for example if the user’s router blocks multicast messages. The mDNS discovery can be completely bypassed by passing
use_mdns: false
to the Client initializer.