Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small cleanups before release #16312

Merged
merged 9 commits into from
Feb 24, 2025
Merged

Small cleanups before release #16312

merged 9 commits into from
Feb 24, 2025

Conversation

snipe
Copy link
Owner

@snipe snipe commented Feb 24, 2025

Small cleanups in layout and some RMB for soft deletes

Copy link

what-the-diff bot commented Feb 24, 2025

PR Summary

  • Enhanced Exception Handling: Made improvements to the mapping between the assetmodels.index route and models.index
  • Optimized AssetModel Controller:
    • Updated the destroy function to accept AssetModel directly, enhancing its efficiency.
    • Simplified the process of getting clones by using AssetModel directly.
    • Removed unnecessary checks for model existence in certain methods to improve performance.
  • Updated UserFilesController: Enhanced readability and reduced database queries by directly using User models as method parameters.
  • Made Corrections to Actionlog Transformer: Altered the user files route to use user instead of userId.
  • Enhanced UX with Breadcrumbs: Updated the breadcrumb paths to include deleted models and users for better navigation.
  • Added Notifications for Deleted Models/Users: Introduced UI alerts for deleted asset models and users.
  • Support for Locale with New Language Keys: Inserted new language keys for "Deleted Asset Models" and "Deleted Users" to cater for multiple languages.
  • Miscellaneous Updates: Corrected alignment and spacing in the user interface, enhanced security with proper authorization checks, and minor corrections in comments and translations.
  • Changed Route Parameters: Improved clarity by changing route parameters from {modelID} and {userId} to {model} and {user}.
  • Enabled Access to Removed Models with withTrashed(): This function was added to multiple routes to allow access to soft-deleted models..
  • Expanded Testing: Added new test case CloneUserTest for the clone user page and included a test in DeleteUserTest to check viewability of a soft-deleted user.
  • Improved Resource Routes: Updated resource routes to include withTrashed() without modifying the middleware or previously defined exceptions.

@snipe snipe merged commit 0bea07e into develop Feb 24, 2025
9 checks passed
@snipe snipe deleted the small_cleanups branch February 24, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant