Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: better error handling for org creation and grafana connection #17

Merged
merged 7 commits into from
May 16, 2022
Merged

Fix: better error handling for org creation and grafana connection #17

merged 7 commits into from
May 16, 2022

Conversation

FarnazZ
Copy link
Contributor

@FarnazZ FarnazZ commented May 15, 2022

Which problem is this PR handling?

  • The situation where the organization exists was not handled in the code
  • If it can't connect to grafana API there wasn't any error handling

Short description of the changes

  • If there is an issue in connecting grafana it shows an error
  • If there is a created organization it goes forward without any issue.

@m-yosefpor m-yosefpor merged commit cf15809 into snapp-incubator:main May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FarnazZ @m-yosefpor