Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
leaving out
std
doesn't really do anything becauseformatting
impliesstd
per https://docs.rs/crate/time/0.3.0/features.However
local-offset
is unused here, and since this is the feature that reintroduces thread-safety shenanigans it seems worthwhile to avoid it if we can.It may be that what this really means is that the current implementation of
timestamp_local()
is in fact not doing anything to localise the timestamp, and that's a bug. I'm in the UTC timezone, so it's not quite straightforward for me to test this!Edit: yeah, I'm pretty sure that there is no localisation going on. Probably what you really want is
the implementation of
time::OffsetDateTime::now_utc()
is exactly what you currently have intimestamp_local()
I'll submit a second MR and you can choose!