Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configurable base branch name #5

Merged
merged 2 commits into from
Nov 28, 2022

Conversation

TheAlbertDev
Copy link
Contributor

Accepts a new input, base_branch_name, to indicate the name of
the branch containing the README file to be updated. Default
main.

Why:

Closes #4

What's being changed:

  base_branch_name:
    description: "Option name of the base branch (default: main)."
    required: false
    default: "main"

Check off the following:

  • For workflow changes, I have verified the Actions workflows function as expected.
  • For content changes, I have reviewed the style guide.

Accepts a new input, `base_branch_name`, to indicate the name of
the branch containing the README file to be updated. Default
`main`.
Copy link
Contributor

@sinsukehlab sinsukehlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!
This PR helps CI course to work.

@TheAlbertDev
Copy link
Contributor Author

This repo doesn't seem very active... I have tagged the relevant commit in the fork (v1.2.0-beta) so that anyone who wants to can use the proposed changes until they are integrated into the repository someday. The only change to the GitHub action is:

- uses: skills/action-update-step@v1
+ uses: TheAlbertDev/[email protected]

@sinsukehlab
Copy link
Contributor

Thanks for sharing.
I have edited yaml files in my generated CI course to use your fork and it works pretty well.
I think this repo is not very active because it is not a course.
Opening a relevant issue in CI course may make this repo more active.

Copy link

@QUGL-98-06-15 QUGL-98-06-15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TheAlbertDev:feature/run-on-different-branch

@heiskr heiskr requested a review from a team October 19, 2022 20:47
@heiskr heiskr merged commit 813162e into skills:main Nov 28, 2022
@github-actions
Copy link

🎉 This PR is included in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@sinsukehlab
Copy link
Contributor

$BASE_BRANCH_NAME env is not set.

Copy link

@Domsbrother Domsbrother left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Run the Action in a branch other than the main branch.
6 participants