Fix for the D8 compiler integration #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the D8 compiler integration. Because the D8 compiler options differ from those provided by the dex compiler, the <dex> tag cannot be used for D8 configuration. There is no way to set e.g. the minApi within the <dex> tag, because the DexMojo defines no corresponding parameter. This commit separates the two configurations and introduces a new <d8> tag for D8 compiler configuration.
If you want to use the D8 compiler, you can use the following plugin configuration in your pom:
<dexCompiler>d8</dexCompiler>
<d8>
<minApi>26</minApi>
...
</d8>
Signed-off-by: Christoph Fiehe <[email protected]>
|
From what I can tell this is an incompatible change right? So users are forced to update their pom if they adopt this potentially new release of the plugin. |
|
@william-ferguson-au what do you think... this seems a follow up to your PR https://github.com/simpligility/android-maven-plugin/pull/781/files |
|
There are no changes necessary for all those users who migrate to a follow-up release containing this extension. If you do not specify the |
|
Sorry @mosabua I'm too tired to reason this one through. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the D8 compiler integration. Because the D8 compiler options differ from those provided by the dex compiler, the
<dex>tag cannot be used for D8 configuration. There is no way to set e.g. the minApi within the<dex>tag, because the DexMojo defines no corresponding parameter. This commit separates the two configurations and introduces a new<d8>tag for D8 compiler configuration.If you want to use the D8 compiler, you can use the following plugin configuration in your pom:
Signed-off-by: Christoph Fiehe [email protected]