Added unpackOutputDirectory and includeNonClassFiles to the unpack goal #779
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new two configuration options to make the
unpack
goal more precise:unpackOutputDirectory
to change the originally hardcodedandroid-classes
directory.includeNonClassFiles
to allow non-.class
files that are not specified in the manifest.Rationale
Since I have to use Retrolambda, I have to extract v52-bytecode JAR classes from the repository before downgrading the classes bytecode. As of 2018-09-26, I used the following methods described here:
org.apache.maven.plugins:maven-dependency-plugin
to extract non-AAR dependencies.org.apache.maven.plugins:maven-antrun-plugin
to extract AAR contents becauseorg.apache.maven.plugins:maven-dependency-plugin
can't do the job.net.orfjackal.retrolambda:retrolambda-maven-plugin
to downgrade the bytecode.com.simpligility.maven.plugins:android-maven-plugin
with the exclusion filter enabled to process downgraded stuff only.Since the use of
org.apache.maven.plugins:maven-dependency-plugin
andorg.apache.maven.plugins:maven-antrun-plugin
is error-prone (concrete groups IDs, artifact IDs and versions should be specified directly in paths), it turns out that theunpack
goal fromnet.orfjackal.retrolambda:retrolambda-maven-plugin
can replace the first two plugins. For example,