Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't generate existing R #769

Merged
merged 3 commits into from
Jan 24, 2018
Merged

Don't generate existing R #769

merged 3 commits into from
Jan 24, 2018

Conversation

william-ferguson-au
Copy link
Contributor

Don't generate R.java if one has already been generated for that package in the compile classpath.
This stops extra R javas being generated for a test-apk that will mirror those from the target APK.

…age in the compile classpath.

This stops extra R javas being generated for a test-apk that will mirror those from the target APK.
@william-ferguson-au
Copy link
Contributor Author

@mosabua could you check over and merge this please.

@mosabua
Copy link
Member

mosabua commented Jan 23, 2018

lgtm - wanna add a changelog entry ? Then I can merge and if you want cut a new release

@william-ferguson-au
Copy link
Contributor Author

Done. Ta

@mosabua mosabua merged commit 981aab0 into master Jan 24, 2018
@mosabua mosabua deleted the dont-generate-existing-R branch January 24, 2018 17:41
@mosabua
Copy link
Member

mosabua commented Jan 24, 2018

need a release?

@william-ferguson-au
Copy link
Contributor Author

No :-) I generally run off my own version until the AMP releases catch up with me.
Have been thinking that we need to overhaul all the Mojos and remove the unnecessary implementation inheritance. It's polluting the params for almost all the Mojos so that it's really not clear what params a Mojo actually needs or cares about.

This is especially problematic when you look at the doco in the generated goals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants