Fix buildConfigConstants parameter

[WonderCsabo]

Fixes #722.

[william-ferguson-au]

How was the test (NB not an example) passing?

[WonderCsabo]

@william-ferguson-au sorry i am not sure what you mean. I ran mvn install, and everything passed.

BTW, the CI should be fixed. :)

[william-ferguson-au]

This file 7882632#diff-48446e85d4a0808f1f3e2975d47c60b5 is a test POM. It is not an example.

I want to know why the tests didn't fail BEFORE you made the change.
Is that test POM never used?
Do the tests not check the output in BuildConfig?
Do the tests not check the correct thing?

[WonderCsabo]

Sorry for the confusion. I will rephrase my second commit message.

Apparently, Maven accepted the inner element names that way, so it was still working before!

[mosabua]

Maven collections only work on the outter tag. The inner tag just has to be valid. The tag name is arbitrary. So in this example it could have been

<buildConfigConstants>
  <foo>
    <name>Title</name>
    <value>${project.name}</value>
    <type>String</type>
  </foo>

I am still okay with the merge though so thanks.. we need to probably update the changelog..

[william-ferguson-au]

Changelog already updated.