also extract duplicates from output folder #705
Conversation
|
I am working my way through the PRs to a release at the moment. Should have a release with this hopefully some time next week.. fyi @simpligility/android-maven-plugins-core-committers |
| @@ -21,6 +21,7 @@ | |||
| import com.android.sdklib.build.DuplicateFileException; | |||
| import com.android.sdklib.build.SealedApkException; | |||
| import com.simpligility.maven.plugins.android.AbstractAndroidMojo; | |||
| import com.google.common.io.Files; | |||
There was a problem hiding this comment.
Why is this not using the normal commons-io but the google fork instead?
There was a problem hiding this comment.
hm... sorry.. looks like its not a fork but a powerful replacement. I guess thats fine.
There was a problem hiding this comment.
I can change it. do you mean apache commons-io or is it also in the jdk?
On Jan 19, 2016 5:28 PM, "Manfred Moser" [email protected] wrote:
In
src/main/java/com/simpligility/maven/plugins/android/phase09package/ApkMojo.java
#705 (comment)
:@@ -21,6 +21,7 @@
import com.android.sdklib.build.DuplicateFileException;
import com.android.sdklib.build.SealedApkException;
import com.simpligility.maven.plugins.android.AbstractAndroidMojo;
+import com.google.common.io.Files;Why is this not using the normal commons-io but the google fork instead?
—
Reply to this email directly or view it on GitHub
https://github.com/simpligility/android-maven-plugin/pull/705/files#r50193127
.
There was a problem hiding this comment.
I meant apache commons since I think its already used in the project... just to reduce different tools used. But have a look first .. if its too much effort .. using the google one is fine as well. Btw... is it part of guava?
-also extract duplicates from output folder, not just 3rd party deps -Handle multiple 3rd party deps with the same basename, i.e. classes.jar.
|
Merged and tested locally. Everything works. |
also extract duplicates from output folder
extract duplicates functionality only looked at dependent jars, not the project output folder.