Fixes for provided apk dependency for instrumentation tests #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this may be specific to JDK 6. As in the problem is there building with jdk 6 |
|
@psirosky could u look at this real quick? It is a real issue.. I have a couple projects depending on this change. |
|
I am happy to merge this. Ideally with some feedback from @psorobka and cut a new release soon.. |
|
@psorobka Can I get some feedback please? Thanks in advance. |
|
I'm sorry but I have no idea what is this about. |
|
There are 2 bugs this solves:
|
-add dummy ZipEntry to apk placeholder. to avoid "0 entries" exception -Changed system dependency to use BaseVersion for snapshot versions. I had issue where the ClasspathModifierLifecycleParticipent used the full snapshot version with timestamp for the placeholder and system dependency. But the GenerateSourcesMojo used the SNAPSHOT version without timestamp, resulting in compilation errors.
|
@psorobka do you have a better idea of whats it's about? |
|
@mosabua can you look at this? I promise it is 2 real bugs. |
|
Let me do that tonight.. |
|
I will try to release something soon |
mosabua
added a commit
that referenced
this pull request
Sep 22, 2015
Fixes for provided apk dependency for instrumentation tests
|
Do we have any filed issues that this closes? |
|
I never created an issue.. just the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-add dummy ZipEntry to apk placeholder. to avoid "0 entries" exception.
-Changed system dependency to use BaseVersion for snapshot versions.
I had issue where the ClasspathModifierLifecycleParticipent used the
full snapshot version with timestamp for the placeholder and system dependency.
But the GenerateSourcesMojo used the SNAPSHOT version without timestamp, resulting in compilation errors. Because actual apk classes.jar wasn't getting added to the classpath.
Note: I experience these problems specifically when there wasn't any artifacts in the local repo. I was doing a verify on an aggregator project, which had both the apk and test projects as modules. So the apk had to come from the previous build, instead of the maven repo. I think this had something to do with the problem. I verified that now it consistently works.