Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

658 build config example #659

Merged
merged 4 commits into from
Jan 19, 2016
Merged

658 build config example #659

merged 4 commits into from
Jan 19, 2016

Conversation

spyhunter99
Copy link
Contributor

No description provided.

* master:
  added minimal usage page
  added build invocation for example projects and some related hints
  added some documentation on site generation and content authoring
@mosabua
Copy link
Member

mosabua commented Aug 5, 2015

Can you add an IT test that builds this apk and deploys it and maybe even does some verification?

@spyhunter99
Copy link
Contributor Author

The only verification test possible is to check the generated class file, actually deploying it to android isn't necessary. I can look into it, but I don't have a huge amount of time to donate to this

@mosabua
Copy link
Member

mosabua commented Aug 6, 2015

Just add a test that build the project then and forget about verification.

@spyhunter99
Copy link
Contributor Author

ok i think i found where to add the tests. will push shortly

@spyhunter99
Copy link
Contributor Author

I'm currently getting the following test failure. Doesn't look related to the test project I added. Is this a known issue?

Test set: com.simpligility.maven.plugins.android.AndroidSdkTest

Tests run: 13, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.181 sec <<< FAILURE! - in com.simpligility.maven.plugins.android.AndroidSdkTest
validPlatformsAndApiLevelsWithDiffBuildTools1(com.simpligility.maven.plugins.android.AndroidSdkTest) Time elapsed: 0.124 sec <<< ERROR!
com.simpligility.maven.plugins.android.InvalidSdkException: Invalid SDK: Build-tools 22 not found. Check your Android SDK to install the build tools 22
at com.simpligility.maven.plugins.android.AndroidSdk.getBuildToolInfo(AndroidSdk.java:275)
at com.simpligility.maven.plugins.android.AndroidSdk.getPathForBuildTool(AndroidSdk.java:260)
at com.simpligility.maven.plugins.android.AndroidSdk.getAaptPath(AndroidSdk.java:168)
at com.simpligility.maven.plugins.android.AndroidSdkTest.validPlatformsAndApiLevelsWithDiffBuildTools1(AndroidSdkTest.java:120)

@Shusshu
Copy link
Member

Shusshu commented Aug 7, 2015

I wrote that test.

It cannot find the build-tools 22 which is required for that test

@spyhunter99
Copy link
Contributor Author

Well the tests are added. I also added a ignore flag for the one test that fails. I'm not sure what travis is complaining, but it doesn't look related to the changes

@WonderCsabo
Copy link
Contributor

@spyhunter99 the failure occurred exactly at your test class. Does this pass for you locally? If yes, you should add an echo statement in the Travis script to check out the maven log.

@spyhunter99
Copy link
Contributor Author

Maybe i'm doing something wrong. I'm just running mvn clean install and it's building just fine here

@spyhunter99 spyhunter99 closed this Sep 4, 2015
@spyhunter99 spyhunter99 reopened this Sep 4, 2015
mosabua added a commit that referenced this pull request Jan 19, 2016
@mosabua mosabua merged commit fd04943 into simpligility:master Jan 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants