-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature choose which version of the build tools to use #637
Conversation
@simpligility/android-maven-plugins-core-committers +1 or merge :) I've added some unit tests and tested it on a project with different configuration |
If anyone can help out with travis that would be cool |
You have to install build tools 22 in Travis in this line. Just adding |
Already tried that |
And what happened? Does it install the SDK? Is this working for you locally? |
Nop it times out it seems... I don't have travis locally. I thought it was |
I meant the PR works for on the local machine? With your local SDK setup,
no travis.
|
Yes ofc only travis is not working. |
+1 |
I managed to build with the built-in Travis Android support. But it is reproducing the same failures. I do not know why it cannot find build tools 22. 😖 |
@malachid last time you worked on travis right? |
If its building locally we should merge and then look at travis. I already had to disable the IT test run there since it kept failing even though it worked locally. Travis supposedly now has native android support but we have not migrated to that yet (or even tried). |
Feature choose which version of the build tools to use
yes please Benoit Billington |
@WonderCsabo anything is better than the simple install we run now .. so yes please. |
OK, i am looking at it. |
This PR adds the ability to choose which the version of the build tools we want to use.
A) When a user does not set the build tools it will behaves exactly as it is now.
B) If the user decide to put a build tool it will try to find that version of the build tools or throw an exception.
I prefer this approach over the one where if it cannot find the build tools specified it will take the latest one... I assume if I user set that value there must be a reason and we don't want to use another build tool version. (With a CI you can be sure your PC and the CI uses the same build tools)
Note about the code:
When we receive an AndroidTarget for version 19 from the google lib it gives us the correct target but the target will always try to find the latest build tools.
So I decided to put a seperate parameter for the build tools (same as gradle btw)