Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature choose which version of the build tools to use #637

Merged
merged 5 commits into from
Jun 9, 2015

Conversation

Shusshu
Copy link
Member

@Shusshu Shusshu commented Jun 5, 2015

This PR adds the ability to choose which the version of the build tools we want to use.

<sdk>
     <platform>22</platform>
<!--        <buildTools>19.0.0</buildTools> -->
</sdk>

A) When a user does not set the build tools it will behaves exactly as it is now.

B) If the user decide to put a build tool it will try to find that version of the build tools or throw an exception.
I prefer this approach over the one where if it cannot find the build tools specified it will take the latest one... I assume if I user set that value there must be a reason and we don't want to use another build tool version. (With a CI you can be sure your PC and the CI uses the same build tools)

Note about the code:
When we receive an AndroidTarget for version 19 from the google lib it gives us the correct target but the target will always try to find the latest build tools.
So I decided to put a seperate parameter for the build tools (same as gradle btw)

@Shusshu
Copy link
Member Author

Shusshu commented Jun 5, 2015

@simpligility/android-maven-plugins-core-committers +1 or merge :) I've added some unit tests and tested it on a project with different configuration

@Shusshu
Copy link
Member Author

Shusshu commented Jun 5, 2015

If anyone can help out with travis that would be cool

@WonderCsabo
Copy link
Contributor

You have to install build tools 22 in Travis in this line. Just adding build-tools-22.0.1 should work.

@Shusshu
Copy link
Member Author

Shusshu commented Jun 5, 2015

Already tried that

@WonderCsabo
Copy link
Contributor

And what happened? Does it install the SDK?

Is this working for you locally?

@Shusshu
Copy link
Member Author

Shusshu commented Jun 5, 2015

Nop it times out it seems... I don't have travis locally. I thought it was
only in the cloud.

@WonderCsabo
Copy link
Contributor

WonderCsabo commented Jun 5, 2015 via email

@Shusshu
Copy link
Member Author

Shusshu commented Jun 5, 2015

Yes ofc only travis is not working.

@william-ferguson-au
Copy link
Contributor

+1

@WonderCsabo
Copy link
Contributor

I managed to build with the built-in Travis Android support. But it is reproducing the same failures. I do not know why it cannot find build tools 22. 😖

@Shusshu
Copy link
Member Author

Shusshu commented Jun 7, 2015

@malachid last time you worked on travis right?

@mosabua
Copy link
Member

mosabua commented Jun 9, 2015

If its building locally we should merge and then look at travis. I already had to disable the IT test run there since it kept failing even though it worked locally. Travis supposedly now has native android support but we have not migrated to that yet (or even tried).

Shusshu added a commit that referenced this pull request Jun 9, 2015
Feature choose which version of the build tools to use
@Shusshu Shusshu merged commit ebb06b2 into master Jun 9, 2015
@Shusshu Shusshu deleted the feature-buildtools branch June 9, 2015 07:49
@WonderCsabo
Copy link
Contributor

@mosabua i already tried Travis, but i had to comment out emulator and NDK. Should i send a PR and try to make them work?

@Shusshu
Copy link
Member Author

Shusshu commented Jun 9, 2015

yes please

Benoit Billington

@mosabua
Copy link
Member

mosabua commented Jun 9, 2015

@WonderCsabo anything is better than the simple install we run now .. so yes please.

@WonderCsabo
Copy link
Contributor

OK, i am looking at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants