Fixed a NullPointerException if versionNamingPattern is not defined #622
Conversation
|
That's weird because the default value is "" and your commit remove the default value... I'll see if I can test this later or maybe someone else can try that Could you try with the latest maven? Edit: Probable means that the Parameter with default value = "" means null.... |
|
Based on what I managed to learn about Maven (to be precise, Maven Plugin API), you are right about "Probable means that the Parameter with default value = "" means null". Setting default value to any empty string - nothing but whitespace - does translate into null. Hence defaultValue="" makes no sense and does not work. UPDATE Tested with Apache Maven 3.1.1, 3.2.1, and finally with 3.3.1. No difference in Plugin API behavior; setting default value to empty string means null and AMP fails with NPE. |
Fixed a NullPointerException if versionNamingPattern is not defined
|
Yes this is good. |
|
Imho not worth it. It doesnt block anyone really. I would rather wait and get a few more other things in. |
|
Uh-oh, my bad in not really test-running the fallback. You're right about the empty string behavior; removing the property did cause NPE, sorry about that. Time to build more Java intuition... |
|
Just got bit by this. Only way around it was to provide a magic regex expression in the Java regex syntax to get things passing again. |
Hello everyone,
It seems as one major use case was overlooked while working on #605 and #606. What happens if Maven descriptor maintainer DOES NOT include or declare the versionNamingPattern property? Or leaves it blank. Judging by the way Maven behaves, the propery would evaluate to null, and cause a NullPointerException when accessing the value in VersionGenetator class constructor. Setting Parameter annotation defaultValue to empty parenthesis does not help much.
Hence there are two options. Either something is totally wrong with Maven 3.2.1 I am using (which could be the case after all), or the fix proposed here solves the issue at hand, without breaking anything.