Configurable encoding for listing text files #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think read only.. yes. And default value should maybe be the platform encoding and not hardcoded to be UTF-8.. wdyt @simpligility/android-maven-plugins-core-committers |
|
And I dont think we want to support a case where the encoding is different from the rest of the source code until we see someone requests that.. |
|
I agree I just wrote down all the possibilities.
About encoding: maybe we should follow the behavior of the resources plugin
: use platform encoding by default, but show a warning.
|
|
BTW the resources plugin is not using read only for encoding, nor the maven
page in the OP (which may be a bad thing and against the purpose of the
global property).
|
|
Good idea about use platform encoding and warn. And I still think we should do read only. Just because others do it wrong... |
This makes the Mojo to use a configurable encoding (project.build.sourceEncoding) for reading text files when publishing listing to Play, instead of just relying to the platform default encoding (which can differ from the text file encoding).
WonderCsabo
force-pushed
the
601_publishListingEncoding
branch
from
a1def2d to
a062a34
Compare
|
I updated the PR per @mosabua request. |
|
Any update on this @mosabua ? |
|
Sorry ... been hung up on other stuff. Let me look at this tonight,.. I want to get the rest of the open PRs merged and cut a release after updating the SDK tool libraries as well. |
|
Looks good. |
mosabua
added a commit
that referenced
this pull request
Mar 19, 2015
Configurable encoding for listing text files
|
No problem! Thanks for reviewing and merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #601. I followed this guide to use the property. From my understanding, this property is not defined in the Maven model at all, since can be null. I do not think we can force users to define it, so i decided to use a default value (UTF-8). But i am open to any suggestions on this. Also i am wonder: should we make this read-only? In that case, users could not set it in the mojo config, only with the global property (however, in special situations they may want to use a different value for that).