Deprecate MergeManifest Parameter from the GenerateSourcesMojo as it is ... #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is replaced by the Manifest Merger v2. Fixed javadoc tag Added usage example of the Manifest Merger V2 (tictactoe)
|
Provided this passes the build with IT tests locally for you this is a +1 from me ;-) |
|
Not all tests works but as I have only changed tictactoe and that test works. Good enough :) |
Shusshu
added a commit
that referenced
this pull request
Jan 12, 2015
Deprecate MergeManifest Parameter from the GenerateSourcesMojo as it is ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...replaced by the Manifest Merger v2.
Fixed javadoc tag
Added usage example of the Manifest Merger V2 (tictactoe)
@mosabua can you sign this off ? no functionality changes, 1 deprecation and 1 example