-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for issues/485 #493
Fix for issues/485 #493
Conversation
I will have a look in a few hours and merge it provided it works ;-) |
4428082
to
676003b
Compare
The travis build failed with compilation failures on the example projects. I will confirm that to be the case and if so .. you gonna have to check it out ;-) |
Got it down to one failing test, will see what I broke... |
Excellent .... |
So the official build timed out but I had a pass from my branch : https://travis-ci.org/secondsun/maven-android-plugin. |
Weird.. its still failing for me locally. I will have to see whats up later.. |
@mosabua Which tests are failing locally? |
9f0c6db
to
832fd81
Compare
I've rebased the PR against the latest master, travis seems happy. |
@mosabua I would really like to get this merged. It will make interacting with Netbeans (my preferred IDE) much easier. What do you need from me? |
@secondsun Think Manfred is on vacation just now - I'll try to take a look at what he has done and merge this in for you if I can. It would probably not make it into a release until Manfred is back though - we are still relying on his release-foo for actual releases. |
@JohanLindquist Thanks. |
I fixed my tests, reopening #485