Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issues/485 #493

Merged
merged 7 commits into from
Nov 20, 2014
Merged

Fix for issues/485 #493

merged 7 commits into from
Nov 20, 2014

Conversation

secondsun
Copy link
Contributor

I fixed my tests, reopening #485

@mosabua
Copy link
Member

mosabua commented Oct 29, 2014

I will have a look in a few hours and merge it provided it works ;-)

@mosabua
Copy link
Member

mosabua commented Oct 30, 2014

The travis build failed with compilation failures on the example projects. I will confirm that to be the case and if so .. you gonna have to check it out ;-)

@secondsun
Copy link
Contributor Author

Got it down to one failing test, will see what I broke...

@mosabua
Copy link
Member

mosabua commented Oct 30, 2014

Excellent ....

@secondsun
Copy link
Contributor Author

So the official build timed out but I had a pass from my branch : https://travis-ci.org/secondsun/maven-android-plugin.

@mosabua
Copy link
Member

mosabua commented Oct 30, 2014

Weird.. its still failing for me locally. I will have to see whats up later..

@secondsun
Copy link
Contributor Author

@mosabua Which tests are failing locally?

@secondsun
Copy link
Contributor Author

I've rebased the PR against the latest master, travis seems happy.

@secondsun
Copy link
Contributor Author

@mosabua I would really like to get this merged. It will make interacting with Netbeans (my preferred IDE) much easier. What do you need from me?

@nahojkap
Copy link
Member

nahojkap commented Nov 7, 2014

@secondsun Think Manfred is on vacation just now - I'll try to take a look at what he has done and merge this in for you if I can. It would probably not make it into a release until Manfred is back though - we are still relying on his release-foo for actual releases.

@secondsun
Copy link
Contributor Author

@JohanLindquist Thanks.

mosabua added a commit that referenced this pull request Nov 20, 2014
@mosabua mosabua merged commit b5499ee into simpligility:master Nov 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants