fix: added triples and presigs back to storage and fix EXPIRE on used #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volovyks
approved these changes
Jan 8, 2025
| -- Add the triples to the used set and set expiration time. Note, HSET is used so | ||
| -- we can expire on each field instead of the whole hash set. | ||
| redis.call("HSET", KEYS[3], id1, "1", id2, "1") | ||
| redis.call("HEXPIRE", KEYS[3], ARGV[1], "FIELDS", 2, id1, id2) |
| For M1 you may want to pull the following image instead: | ||
|
|
||
| ```BASH | ||
| docker pull ghcr.io/near/sandbox:latest-aarch64 |
There was a problem hiding this comment.
Isn't this still relevant?
There was a problem hiding this comment.
nope, we don't need sandbox at all
ppca
reviewed
Jan 8, 2025
ppca
approved these changes
Jan 9, 2025
| if redis.call("SISMEMBER", used_key, triple_id) == 1 then | ||
| if back == "true" then | ||
| redis.call("HDEL", used_key, triple_id) | ||
| elseif redis.call("HEXISTS", used_key, triple_id) == 1 then |
There was a problem hiding this comment.
what's the difference between HEXISTS and SISMEMBER?
There was a problem hiding this comment.
Theyre methods for different types. One is for set and one is for map
|
And just for my own clarification: our current code does not treat back=true/false differently? |
before this PR, there was no |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backis added for cases where we are sure we want to add these back to storage. Mainly added back to circumvent the cases of inconsistency when one node decides to drop a triple and presignature but others do not or were not aware of it. In the current code, they would never drop these as they do not own them and will purely sit in storage. It's better to have the chance later to use them otherwise we'd still be at the same problem of taking up maximum amount of triples/presignatures we can have per the config.HEXPIREwhereEXPIREwas deleting the whole set before, which isn't ideal for when we want to expire per triple id or presignature id. Especially when a new triple or presignature gets used, the time to live on this set would get updated and effectively never get deleted.