Atomic insertion of presignatures and triples #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ChaoticTempest I've fixed the tests |
| .key(self.triple_key()) | ||
| .arg(triple.id) | ||
| .arg(triple) | ||
| .arg(mine.to_string()) |
There was a problem hiding this comment.
can't we just send it as a bool instead of a string?
There was a problem hiding this comment.
By default, it is serialized as o or 1, so our script will look like if mine == "1". True/false is more readable both in code and when debugging redis storage directly.
ChaoticTempest
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Insert and take operations must be atomic. Lua may seem an overhead when we have 2 simple operations, but I want to have a unified approach for storage and flexibility. Already planning to extend those scripts with additional checks.
Also, scripts can be preloaded to Redis, so there is no need to transfer and build them on each call. We may add that optimization when required.