Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mpc recovery #67

Merged
merged 4 commits into from
Dec 17, 2024
Merged

Remove mpc recovery #67

merged 4 commits into from
Dec 17, 2024

Conversation

volovyks
Copy link
Contributor

Since we are not planning to work on this code base - let's remove it. It should make future refactoring, building, and testing speed optimizations easier.
This PR does not include any optimizations in the project structure, let's do that in a separate PR.

@@ -1,86 +0,0 @@
# Manually Deploying mpc-recovery to GCP

## Requirements
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@auto-mausx not sure if it is useful for us now

@auto-mausx
Copy link
Contributor

Can we remove the running services? If so let me destroy the TF resources for MPC recovery first, then we can merge this and remove the terraform code.

@ppca
Copy link
Contributor

ppca commented Dec 16, 2024

Can we remove the running services? If so let me destroy the TF resources for MPC recovery first, then we can merge this and remove the terraform code.

That is a good idea

Copy link
Contributor

@ChaoticTempest ChaoticTempest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since you moved the config.toml file to the parent dir, you need to remove one .. so it's pointing to the right target folder

@volovyks
Copy link
Contributor Author

volovyks commented Dec 16, 2024

@ChaoticTempest can you please point me at what path you are referring to?

@ChaoticTempest
Copy link
Contributor

@volovyks actually nevermind, the git diff looked funky because it showed moving one file to another

@volovyks volovyks merged commit f735094 into develop Dec 17, 2024
2 of 3 checks passed
@volovyks volovyks deleted the serhii/remove-mpc-recovery branch December 17, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants