feat: use IterableMap for near contract #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e/refactor-signature
…e/refactor-signature
ChaoticTempest
force-pushed
the
phuong/feat/contract-iterable-map
branch
from
4d7efca to
becb428
Compare
volovyks
previously approved these changes
Feb 13, 2025
There was a problem hiding this comment.
Nice! Why haven't we used this structure before? Probably because it’s not in collections.
From what I see, the only breaking change here is the SignatureResult part. Overall, I do not want to invest time in this API since it is unclear if we need it. Maybe we will rewrite it to work like the one on Ethereum, with a significantly simplified design.
We can afford breaking changes here now or after the release since technically we are not releasing on NEAR. We will need to fix some things in our infra and tooling, let's merge this if you are ok with that.
|
SignatureResult isn't a breaking change since it's only used within the contract |
ChaoticTempest
dismissed
volovyks’s stale review
The base branch was changed.
volovyks
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the spirit of breaking changes, use
IterableMapinstead ofLookupMapjust so we don't maintain that pesky request counter anymore.