Skip to content
This repository was archived by the owner on Dec 19, 2020. It is now read-only.

bash to sh #239

Open
wants to merge 1 commit into
base: 0.13.x
Choose a base branch
from
Open

bash to sh #239

wants to merge 1 commit into from

Conversation

davidmlw
Copy link

The docker image has no bash. Use sh instead.

@mmjconolly
Copy link
Contributor

Please target branches at master

@mmjconolly
Copy link
Contributor

In master we handle this by adding bash to the actions container

RUN apk add bash --no-cache

@richardxia
Copy link
Member

By the way, this change also won't work correctly on all systems, since I used bash-specific syntax (the [[ ]]) which are not part of the POSIX standard. I know for a fact that dash installed as /bin/sh on Ubuntu-based systems will not support that syntax.

If you just use the wit action targeting the latest commit on master, you should get bash installed in the Docker container and it should work around this issue.

@davidmlw
Copy link
Author

By the way, this change also won't work correctly on all systems, since I used bash-specific syntax (the [[ ]]) which are not part of the POSIX standard. I know for a fact that dash installed as /bin/sh on Ubuntu-based systems will not support that syntax.

If you just use the wit action targeting the latest commit on master, you should get bash installed in the Docker container and it should work around this issue.

I see. Seems better way is to apk add bash

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants