Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix typo in authPluginName property #3210

Merged
merged 3 commits into from
Mar 5, 2025

Conversation

judasnow
Copy link
Contributor

fix typo in lib/packets/handshake.js

@wellwelwel
Copy link
Collaborator

wellwelwel commented Nov 18, 2024

Thanks, @judasnow 🙋🏻‍♂️

There is a PR in progress for it (#2143), but I'll keep this PR open until a resolution 🤝

EDIT: Since #2143 already requires a rebase, I'm merging this PR first.

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.98%. Comparing base (be22202) to head (aaf96e2).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3210   +/-   ##
=======================================
  Coverage   88.98%   88.98%           
=======================================
  Files          86       86           
  Lines       13504    13504           
  Branches     1560     1560           
=======================================
  Hits        12016    12016           
  Misses       1488     1488           
Flag Coverage Δ
compression-0 88.98% <100.00%> (ø)
compression-1 88.98% <100.00%> (ø)
static-parser-0 86.55% <100.00%> (ø)
static-parser-1 87.37% <100.00%> (ø)
tls-0 88.39% <100.00%> (ø)
tls-1 88.75% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wellwelwel wellwelwel changed the title fix: 🐛 typo chore: fix typo in authPluginName property Nov 18, 2024
@wellwelwel wellwelwel merged commit fe3a11c into sidorares:master Mar 5, 2025
100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants