Skip to content
This repository was archived by the owner on Mar 18, 2018. It is now read-only.

bashism in updateSymbolicLink #147

Closed
nkovacs opened this issue Aug 18, 2017 · 3 comments
Closed

bashism in updateSymbolicLink #147

nkovacs opened this issue Aug 18, 2017 · 3 comments
Assignees
@gregberge
Labels
bug

Comments

@nkovacs
Copy link

nkovacs commented Aug 18, 2017 •
edited
Loading

This is a bashism: f47470e

You should instead use if [ -d current ] && ! [ -L current ]; so that it works on all posix shells.
@pgsimon
Copy link

pgsimon commented Aug 18, 2017

+1

@gregberge gregberge added the bug label Aug 21, 2017
@gregberge gregberge self-assigned this Aug 21, 2017
@gregberge
Copy link
Member

@nkovacs thanks, open to PR

nkovacs added a commit to nkovacs/shipit-deploy that referenced this issue Aug 22, 2017
@nkovacs
Use [ instead of [[
e93a59a 
[[ is a bashism, [ is portable.

Fixes shipitjs#147
@nkovacs nkovacs mentioned this issue Aug 22, 2017
Closed
@gregberge
Copy link
Member

shipitjs/shipit#156

@gregberge gregberge mentioned this issue Nov 1, 2017
Closed
36 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gregberge gregberge

Labels
bug
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gregberge @nkovacs @pgsimon