Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update view position links #9152

Merged
merged 5 commits into from
Mar 26, 2025

Conversation

JoeChenJ
Copy link
Contributor

Description

Updates View Position links to /wallet/earn as /earn is gone

Issue (if applicable)

closes #9147

Risk

High Risk PRs Require 2 approvals

None

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

Engineering

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

Screenshots (if applicable)

@JoeChenJ JoeChenJ requested a review from a team as a code owner March 26, 2025 07:21
@JoeChenJ
Copy link
Contributor Author

Also noticed that we're using /earn here: c6279d0b8adedd3d1c885771285bda8

Should we just remove the button?

@NeOMakinG
Copy link
Collaborator

Also noticed that we're using /earn here: c6279d0b8adedd3d1c885771285bda8

Should we just remove the button?

Yes we should, we are removing all those links (because the earn page has been removed)

Copy link
Collaborator

@NeOMakinG NeOMakinG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://jam.dev/c/6ca1675a-d912-4293-adfb-34702252c99d

Should be good! Thanks for the contrib, I also pushed a dead code removal while at it

@NeOMakinG NeOMakinG enabled auto-merge (squash) March 26, 2025 09:08
@NeOMakinG NeOMakinG force-pushed the Fix_view_position_link branch from 4cbfd53 to 6bff47d Compare March 26, 2025 09:25
@NeOMakinG NeOMakinG merged commit 21fdcfa into shapeshift:develop Mar 26, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants