Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dynamic hash routing #9093

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from
Draft

Conversation

0xApotheosis
Copy link
Member

Description

Implements dynamic hash routing so we can:

  • Clean up our URL paths by removing the /# for non-IPFS deployments
  • Keep our fleek IPFS deployment working by keeping the /# when the fleek URL is detected

Issue (if applicable)

Closes #8948

Risk

Small - assuming routing works during testing for IPFS and non-IPFS deployments, we should be good.

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

N/A

Testing

  • This diff deployed to IPFS should route correctly (i.e. use the hash routing)
  • The diff deplored to production should route correctly (no hash routing)

Engineering

TODO - I'll monkey-patch a yml file before opening this to deploy to IPFS and confirm it all works as expected.

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

TODO

Screenshots (if applicable)

N/A

@gomesalexandre gomesalexandre self-requested a review March 20, 2025 22:16
@0xApotheosis 0xApotheosis force-pushed the dynamic-hash-routing branch from 0522f19 to 2fcfeb4 Compare March 27, 2025 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove /#/ base URL in routing
1 participant