-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: lazy Tx history / balance charts hasta la vista #9078
base: develop
Are you sure you want to change the base?
Conversation
// Only fetch if we're connected, not currently loading (this one is weird as we may be going back and forth between loading and idle) | ||
// *and* as a last resort *if* we're not fetching Tx history, which is a bit of a hack, but it's a last resort to avoid blocking the main thread |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not strictly part of this PR but might as well given our current stance on opportunities, will help later refactor. This was spewing a lot of XHRs on app load without a wallet, which was turbo annoying when trying to improve XHRs perfs.
ac6e3be
to
e94ea02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same as previous <DashboardChart />
, without the chart. Think we should be safe to remove it as part of this PR?
Actually ready but moving to draft, pending discussions with @twblack88. We may want to change something major here which will cause rewrite/refactor so let's not waste review time for now. |
Description
Makes the Tx history lazy, one page per account on initial load, then the rest is all user-fetched.
Issue (if applicable)
Risk
Extremely high theoretically, Tx history is a huge one.
Worst case scenario, Tx history is entirely rekt.
Realistically, you still get your first page of Tx and your incoming Tx history, the real risk is on:
Testing
TESTING NOTES⚠️ : When comparing Txs history after loading more, you may notice that:
Those are both expected. Loading more does precisely that, loads more pages. However, not all accounts may have pages for the same time range, e.g
Actual testing:
Engineering
Operations
Screenshots (if applicable)
https://jam.dev/c/4cf74bff-cabe-4604-8034-1bef8a598914
https://jam.dev/c/e24aa7f0-552b-4aab-abbf-bc340e21aea6
https://jam.dev/c/614a8898-3d8d-4ce4-9cf7-079b2ebf76cf