Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: vite follow up #9073

Draft
wants to merge 9 commits into
base: develop
Choose a base branch
from
Draft

chore: vite follow up #9073

wants to merge 9 commits into from

Conversation

kaladinlight
Copy link
Contributor

@kaladinlight kaladinlight commented Mar 18, 2025

Description

  • leverage polyfill plugin and remove manual polyfills/dependencies
  • vite dependencies as dev dependencies
  • use node: protocol imports
  • fix verify hash script
  • remove dist imports
  • remove missed react scripts files/patches
  • cleanup vite config
  • update vitest

TODO:

  • local dev (esbuild) polyfills

Nice To Have:

  • include source maps for production debugging
  • improved chunking

Issue (if applicable)

N/A

Risk

High Risk PRs Require 2 approvals

Medium - polyfills and vite config touched, gotta make sure everything still works!

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

  • Ensure builds still work for the various environments
  • Spot check the app to make sure there isn't anything weird with the polyfills

Engineering

☝️

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)
  • General spot check, should be no visible difference

Screenshots (if applicable)

Copy link
Collaborator

@NeOMakinG NeOMakinG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spent the whole morning trying to unrug the polyfills, I couldn't come with a proper solution yet... Any plugins doesn't work with our current configuration, keeping every polyfills as a separate dependencies works thought

I didn't give time to the sourcemap issue yet

I would suggest we keep the polyfil setup we have on develop while other improvements remains legits

I will try to give a look to the production sourcemaps/chunks later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants