-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: vite follow up #9073
base: develop
Are you sure you want to change the base?
chore: vite follow up #9073
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spent the whole morning trying to unrug the polyfills, I couldn't come with a proper solution yet... Any plugins doesn't work with our current configuration, keeping every polyfills as a separate dependencies works thought
I didn't give time to the sourcemap issue yet
I would suggest we keep the polyfil setup we have on develop while other improvements remains legits
I will try to give a look to the production sourcemaps/chunks later
Description
node:
protocol importsdist
importsTODO:
Nice To Have:
Issue (if applicable)
N/A
Risk
Medium - polyfills and vite config touched, gotta make sure everything still works!
Testing
Engineering
☝️
Operations
Screenshots (if applicable)