feat: decouple routes and navbar #9051
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| : !route.disable && !route.hide && !route.mobileNav, | ||
| .filter(route => 'label' in route) | ||
| .filter((route): route is NavRoute => | ||
| isLargerThanMd ? !route.disable && !route.hideDesktop : !route.disable && !route.mobileNav, |
There was a problem hiding this comment.
This won't work with the new types and would require additional narrowing e.g type guards of sorts.
|
gm @JoeChenJ! Thanks for the contribution. I've added some commentst your PR for posteriority and moved to draft rather than closing to keep it clear work had been started from an external contributor, but will eventually close this as we work on this one. I'll cherry-pick your commit as a starting point when we do so. This is an issue we would only want CODEOWNERS to take on, as there is much more to this than just type changes and a whole routing refactor is required, with large risks. Sorry about this! Please consider this closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Decouple routes and navbar.
Top-level routes are now able to be declared without having to add fluff related to navbar.
Issue (if applicable)
closes #9023
Risk
Low
Testing
Engineering
Operations
Screenshots (if applicable)