Resolve a Runtime Issue on Windows with MSVC

[H-YWu]

Bug

On Windows the library compiled with MSVC will suddenly exit without any warning message when calling reach_for_the_arcs(), and results cannot be generated. It turns out that the bug is caused by the reset() function of the struct Profiler in the PoissonRecon code, which uses mutex. However, we need explicit configuration in MSVC if we need a multi-threading runtime library.

Changes

In CMakeListst.txt:

• Add static multi-threading runtime library configuration for MSVC to ensure the PoissonRecon code runs successfully.
• Set CMP0091 policy to NEW to support CMAKE_MSVC_RUNTIME_LIBRARY.

Testing

The changes were tested in the following environment:

• Operating System: Windows 11
• Compiler: MSVC 19.41.34117.0
• IDE: Visual Studio 17 2022
• Build Tool: CMake 3.27.7
• Package Manager: Conda 24.3.0

Based on the same changes to CMakeListst.txt in https://github.com/H-YWu/reach-for-the-arcs-code/tree/windows-build:

All Python scripts in the scripts directory, except fig_many-shapes-experiment.py, were tested once (without ndc). There were several Runtime Warnings such as "MatrixRankWarning: Matrix is exactly singular" during the execution of some scripts, but results were generated successfully.

For https://github.com/H-YWu/gpytoolbox/tree/windows-build, I only tested fig_adding-spheres.py with replacing calling from rfta package with my modified build of gpytoolbox package. The results were generated successfully.

[sgsellan]

Thank you so much for this contribution, Haoyang Wu! None of the usual maintainers of this library have regular access to Windows, so we really appreciate someone double-checking that things work over there as well. Let me run the automated checks to make sure no builds are broken, and I can merge afterwards

[H-YWu]

Thank you so much for this contribution, Haoyang Wu! None of the usual maintainers of this library have regular access to Windows, so we really appreciate someone double-checking that things work over there as well. Let me run the automated checks to make sure no builds are broken, and I can merge afterwards

Thanks for your quick reply, Dr. Sellán! You're welcome! I'm glad I could help ensure compatibility on Windows.