Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

End disabling regions #380

Merged
merged 7 commits into from
Aug 20, 2020
Merged

End disabling regions #380

merged 7 commits into from
Aug 20, 2020
+186 −60

Conversation

paulfd
Copy link
Member

@paulfd paulfd commented Aug 18, 2020 •
edited
Loading

Closes #365

@paulfd paulfd requested a review from jpcima August 18, 2020 22:58
jpcima
jpcima reviewed Aug 19, 2020
View reviewed changes
paulfd added 3 commits August 19, 2020 11:07
@paulfd
Add a helper for playing voices
80aee5a
@paulfd
A region is disabled by end=-1
5c61298
@paulfd
Disabled regions don't need to take up polyphony
cef44cb 
The tests were a bit flaky and the did not seem justified by any behavior in e.g. ARIA
The new tests cover a similar situation which is validated in sforzando
@paulfd paulfd force-pushed the end-disabling-regions branch from ea000c3 to eeb77d9 Compare August 19, 2020 09:09
jpcima
jpcima reviewed Aug 19, 2020
View reviewed changes
@paulfd paulfd force-pushed the end-disabling-regions branch from eeb77d9 to fae0cda Compare August 19, 2020 10:13
paulfd added 2 commits August 19, 2020 19:12
@paulfd
Add special cases for the rate transformation in envelopes
f6e0bb8 
For increasing linear ramps, a 0s ramp is an increment of 1.0
For decaying exponential ramps, a 0s ramp is a multiplicator of 0.0f
@paulfd
Sustain tweaks:
f6f1e68 
- Separate the sustain value from the sustain threshold after which the envelope goes from decay to sustain
- If the sustain value is set to 0, the envelope is freerunning
@paulfd
Copy link
Member Author

paulfd commented Aug 19, 2020

The latest should match the behavior described in #365.

I amended the rate transformation methods for the cases where the timeInSeconds is exactly 0, since by default the decaying envelope for example was actually quite long (around 1 000 samples).

I also believe this could fix #373 since the value for the sustain is taken as-is, and we don't add virtuallyZero to it anymore.

@paulfd paulfd requested a review from jpcima August 19, 2020 17:20
@paulfd paulfd mentioned this pull request Aug 19, 2020
Closed
@paulfd paulfd merged commit c61ab36 into sfztools:develop Aug 20, 2020
@paulfd paulfd deleted the end-disabling-regions branch August 20, 2020 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpcima jpcima

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding end=-1 or ampeg_sustain=0 to *silence region make the voice not counted
2 participants
@paulfd @jpcima