Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Hyrax logger in hyrax:workflow:load Rake task #7043

Merged

Conversation

dmolesUC
Copy link
Contributor

Fixes

Fixes #7042

Summary

Modifies the hyrax:workflow:load Rake task to use Hyrax.logger (if available), rather
than always spin up its own logger.

Type of change (for release notes)

notes-minor

@samvera/hyrax-code-reviewers

@dmolesUC dmolesUC added the notes-minor Release Notes: Non-breaking features label Mar 19, 2025
@dmolesUC dmolesUC changed the title Use Hyrax logger in hyrax:workflow:load Rake task (#7042) Use Hyrax logger in hyrax:workflow:load Rake task Mar 19, 2025
Copy link

github-actions bot commented Mar 19, 2025

Test Results

    13 files  ±0      13 suites  ±0   2h 59m 6s ⏱️ - 8m 55s
 6 832 tests  - 1   6 533 ✅ +6  299 💤 ±0  0 ❌  - 7 
18 102 runs  ±0  17 625 ✅ +7  477 💤 ±0  0 ❌  - 7 

Results for commit 855e078. ± Comparison against base commit cf3f95e.

This pull request removes 368 and adds 367 tests. Note that renamed tests count towards both.
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007efc0d2edac8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f01ff8f3ad8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f44eb3976c8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007efc10408c20>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f01ffbb7bc0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f44e86c9c40>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 01e190bf-cbfa-410a-ab6a-6ed68a131b37
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 1df5fbf9-294b-43e8-bfe1-4a2d8576211c
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 871d87c2-2b73-4b70-b3ad-8b2f67dbdfd1
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 6082da9f-d13f-418a-964f-4e766fdc4c75
…
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f7e7870f500>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fc09f0a76e0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fee628fd498>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f7e77d1f798>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fc09f1299d8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fee634d8e98>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 881b0af8-a37a-4cac-92f8-5665d87a847f
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 4b5d379b-b5fe-493d-86c9-8154e7a40de1
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 90a501bd-261c-4cb2-96a0-79a6af84538e
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 014f664d-69a2-4e9a-9ac7-767177a51468
…

♻️ This comment has been updated with latest results.

@dmolesUC dmolesUC force-pushed the use-hyrax-logger-in-workflow-load-task branch from b7e8bed to 855e078 Compare March 24, 2025 16:10
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@dlpierce dlpierce merged commit 9bd918f into samvera:main Mar 26, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes-minor Release Notes: Non-breaking features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rake task hyrax:workflow:load doesn't respect log config
3 participants