fix(event-form): add error message for each field #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
n0izn0iz
changed the title
n0izn0iz
requested changes
Mar 12, 2025
There was a problem hiding this comment.
I think there is a problem with the error message top margin or padding
see:
Screen.Recording.2025-03-12.at.14.25.32.mov
For the description it's probably okay since otherwise we will have a weird space at the bottom when the desc is filled. But for the title there should be no jump since the message is on same line as counter.
Also there's a superposition of the counter and text in title:
n0izn0iz
requested changes
Mar 13, 2025
…-shown-then-desc-is-too-short
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #250
Fix #228
Fix #217