Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(event-form): add error message for each field #258

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

pr0m3th3usEx
Copy link
Collaborator

@pr0m3th3usEx pr0m3th3usEx commented Mar 12, 2025

  • Add error message for image missing and title
  • Fix error message for location field (undefined)
  • Add char counter for title & description

Fix #250
Fix #228
Fix #217

@pr0m3th3usEx pr0m3th3usEx self-assigned this Mar 12, 2025
Copy link

vercel bot commented Mar 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zenao ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2025 8:00pm

@pr0m3th3usEx pr0m3th3usEx marked this pull request as ready for review March 12, 2025 11:26
@n0izn0iz n0izn0iz changed the title fix: event-form: add error message for each field fix(event-form): add error message for each field Mar 12, 2025
Copy link
Collaborator

@n0izn0iz n0izn0iz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a problem with the error message top margin or padding
see:

Screen.Recording.2025-03-12.at.14.25.32.mov

For the description it's probably okay since otherwise we will have a weird space at the bottom when the desc is filled. But for the title there should be no jump since the message is on same line as counter.

Also there's a superposition of the counter and text in title:
Screenshot 2025-03-12 at 14 24 20

Copy link
Collaborator

@n0izn0iz n0izn0iz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a weird empty space in address input
Screenshot 2025-03-13 at 16 04 51
Screenshot 2025-03-13 at 16 05 15

also still got undefined error message in some cases

Screen.Recording.2025-03-13.at.16.05.49.mov

@pr0m3th3usEx pr0m3th3usEx requested a review from n0izn0iz March 13, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants