Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: add support for integer and NA values #64

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dernst
Copy link

@dernst dernst commented Sep 6, 2018

  • adds support for integers (INTEGER and SMALLINT are read as integers)
  • adds support for NA values for integers and real values: NA values are writing as NULL and NULL is read as NA (for real values all NaN values are treated as NA)

I would probably like to avoid hard-coding the java.sql.Types values in R code. Perhaps we could query these constants in JDBC() when it's first used.

Let me know if you're interested in such changes. We're using these in production currently which seems to work well so far.

@dernst
Copy link
Author

dernst commented Sep 28, 2018

If #8 is going to be merged I'll edit my changes to include it.

@s-u s-u force-pushed the master branch 5 times, most recently from 30654b9 to 7675ca0 Compare March 12, 2021 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants