Convert error line buffer to space indentation #6500
+10
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Originally, I was planning to add a test to this. However, it seems like there's no test facility that is related to this that does error reporting, which I would need to check? Any guidance would be appreciated - thanks. |
The type of indentation is not important for error reporting. However, keeping the indentation as tabs has two issues: 1. rustfmt keeps track of widths, not character offsets. For space indentation, these two are the same. For tab indentation, this leads to issues like [1]. 2. annotate-snippet-rs always format leading tabs as four spaces. Thus, formatter error reporting is not faithful and ranges will not be marked correctly (or need another transformation). Replacing tabs with spaces for error reporting as early as possible solves these issues. [1] rust-lang#6442
naseschwarz
force-pushed
the
fix-hard-tabs-error-reporting-convert-line
branch
2 times, most recently
from
abee1df to
ef2726a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type of indentation is not important for error reporting. However, keeping the indentation as tabs has two issues:
Replacing tabs with spaces for error reporting as early as possible solves these issues.
[1] #6442