-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
itertools bump to 0.12 #6093
itertools bump to 0.12 #6093
Conversation
@klensy thanks for the PR. I took a really quick look at the changelog (thanks for the link), and I'll review it more thoroughly when I've got some time, but I wanted to ask you if you think there are any breaking changes in the |
Don't think so: mentioned breaking changes in changelog should give compile errors if unfixed. |
Okay. I'm mostly wondering if there are any changes in behavior that wouldn't be caught at compile time. |
…crum bump itertools to 0.12 still depend on 0.11 (temporary dupes version): * <del>clippy</del>, rust-lang/rust-clippy#12346 * rustfmt, sigh, rust-lang/rustfmt#6093 https://github.com/rust-itertools/itertools/blob/v0.12.1/CHANGELOG.md removed unused `derive_more` dep from `rustc_middle`
Rollup merge of rust-lang#121584 - klensy:itertools-up, r=Mark-Simulacrum bump itertools to 0.12 still depend on 0.11 (temporary dupes version): * <del>clippy</del>, rust-lang/rust-clippy#12346 * rustfmt, sigh, rust-lang/rustfmt#6093 https://github.com/rust-itertools/itertools/blob/v0.12.1/CHANGELOG.md removed unused `derive_more` dep from `rustc_middle`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally got around to reviewing the v0.12 changelog, and I agree that there don't seem to be any breaking changes that would impact rustfmt.
changelog: https://github.com/rust-itertools/itertools/blob/v0.12.1/CHANGELOG.md