-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/update-comfyui #81
Conversation
…s base image; added COMFYUI_VERSION; removed unneeded stuff
…ia the network storage
python3.8 get-pip.py && \ | ||
python3.9 get-pip.py && \ | ||
python3.10 get-pip.py && \ | ||
python3.11 get-pip.py | ||
python3.11 get-pip.py && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also add 3.12 and 3.13 to the base.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
those are now included
looks like CI needs to re-run - idk if I've seen this before: https://github.com/runpod/containers/actions/runs/13530285469?pr=81 is this a custom runner group? I'm unfamiliar with ubuntu-latest-m |
- [Stable Diffusion 1.5](https://huggingface.co/Comfy-Org/stable-diffusion-v1-5-archive) | ||
- [Stable Diffusion 2.1](https://huggingface.co/stabilityai/stable-diffusion-2-1) | ||
|
||
## Custom Models |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding a note here about persistence. As I understand it, all of /workspace/comfyui/models
is completely deleted upon removing a Pod, unless the pod is connected to a network volume. Is that right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sayhiben that is totally correct, will add this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sayhiben the problem was, that we had no github runner assigned to this repo, but this is solved now and i can take care of all of this! thanks for pointing it out 🫡 |
@sayhiben if you already want to try this out: |
@TimPietruskyRunPod Oh sweet, will take a look. This should massively improve startup time |
Motivation
extra_model_paths.yml
runpod/base
as base imagerunpod/base
to include python 3.11 and 3.12 & added GitHub workflow to build and pushIssues closed