Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/update-comfyui #81

Merged
merged 35 commits into from
Mar 11, 2025
Merged

feat/update-comfyui #81

merged 35 commits into from
Mar 11, 2025

Conversation

TimPietruskyRunPod
Copy link
Collaborator

@TimPietruskyRunPod TimPietruskyRunPod commented Feb 25, 2025

Motivation

  • updated to ComfyUI v0.3.10
  • added support for custom models via extra_model_paths.yml
  • pre-installed popular models (SDXL, SD 1.5, SD 2.1, FLUX.1)
  • upgraded to Python 3.10 (removed Python 3.7)
  • now using runpod/base as base image
  • added GitHub workflow for ci testing
  • configured Jupyter to use Python 3.10
  • updated documentation with model info and usage instructions
  • removed unnecessary components for a cleaner container
  • updated repo README & added contributing guidelines
  • updated runpod/base to include python 3.11 and 3.12 & added GitHub workflow to build and push
  • update the README on runpod.io for a given container repo using a custom github-action

Issues closed

  • DX-119

@TimPietruskyRunPod TimPietruskyRunPod changed the title feat/update comfyui feat/update-comfyui Feb 25, 2025
python3.8 get-pip.py && \
python3.9 get-pip.py && \
python3.10 get-pip.py && \
python3.11 get-pip.py
python3.11 get-pip.py && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also add 3.12 and 3.13 to the base.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

those are now included

@sayhiben
Copy link

looks like CI needs to re-run - idk if I've seen this before: https://github.com/runpod/containers/actions/runs/13530285469?pr=81

is this a custom runner group? I'm unfamiliar with ubuntu-latest-m

- [Stable Diffusion 1.5](https://huggingface.co/Comfy-Org/stable-diffusion-v1-5-archive)
- [Stable Diffusion 2.1](https://huggingface.co/stabilityai/stable-diffusion-2-1)

## Custom Models

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a note here about persistence. As I understand it, all of /workspace/comfyui/models is completely deleted upon removing a Pod, unless the pod is connected to a network volume. Is that right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sayhiben that is totally correct, will add this!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sayhiben added with 024212c

@TimPietruskyRunPod
Copy link
Collaborator Author

looks like CI needs to re-run - idk if I've seen this before:

@sayhiben the problem was, that we had no github runner assigned to this repo, but this is solved now and i can take care of all of this! thanks for pointing it out 🫡

@TimPietruskyRunPod TimPietruskyRunPod self-assigned this Mar 5, 2025
@TimPietruskyRunPod
Copy link
Collaborator Author

@sayhiben if you already want to try this out: runpod/stable-diffusion:comfy-ui-6.0.0

@sayhiben
Copy link

sayhiben commented Mar 5, 2025

@TimPietruskyRunPod Oh sweet, will take a look. This should massively improve startup time

@TimPietruskyRunPod TimPietruskyRunPod merged commit be365bf into main Mar 11, 2025
1 of 2 checks passed
@TimPietruskyRunPod TimPietruskyRunPod deleted the feat/update-comfyui branch March 11, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants