Skip to content
This repository was archived by the owner on Jul 31, 2023. It is now read-only.

Flag machine specific configurations like paths as machine scoped #490

Closed
sandy081 opened this issue Jun 14, 2019 · 3 comments · Fixed by #551
Closed

Flag machine specific configurations like paths as machine scoped #490

sandy081 opened this issue Jun 14, 2019 · 3 comments · Fixed by #551
Assignees
Labels
enhancement Improves upon existing functionality
Milestone

Comments

@sandy081
Copy link

I am developer from VS Code and we introduced Machine Scope for configurations in 1.34 which will help in remote set ups.

I would like to encourage extension authors to adopt to machine scope if you have any settings that you think they are scoped to machine like ruby.interpreter.commandPath

For example, If you have settings that allow users to customize an executable path that exists on the machine in which extension is running, then you can tag such settings as machine scoped. This will let VS Code to read this setting from the location where the extension is running.

  • When extension is running locally, VS Code reads this setting only from User settings on the same machine.
  • When extension is running remotely, VS Code reads this setting only from Remote settings on the remote machine.

If the extension is running remotely in a remote set up, then this will help the extension not to read paths configured in local machine user settings and bail as the paths not exist in the remote machine.

Note that machine scoped settings are overridable only in user or remote settings.

@wingrunr21
Copy link
Collaborator

Hi @sandy081 thanks for the issue. I'll keep this in mind as I add support for remote workspaces.

@wingrunr21 wingrunr21 added the enhancement Improves upon existing functionality label Jun 14, 2019
@wingrunr21 wingrunr21 self-assigned this Jun 14, 2019
@sandy081
Copy link
Author

@wingrunr21 I see you are using isExecutable for this configuration, it is deprecated long time back. You can use machine scope instead.

@wingrunr21
Copy link
Collaborator

Most of those settings are legacy as we transition everything over to the language server so..."using" is a better descriptor.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Improves upon existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants