Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a helper method to generate GIF Snapshots #419

Merged
merged 10 commits into from
Mar 7, 2023

Conversation

rpaschoal
Copy link
Contributor

These changes add a helper method to generate GIF snapshots. Here is an example output of the input_3sec.mp4 resource test file with default parameters:

81877f52-a2f6-44bf-be33-e4fc5fda7950-out

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 86.95% and project coverage change: +0.45 🎉

Comparison is base (dc88862) 74.22% compared to head (3dc2fff) 74.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #419      +/-   ##
==========================================
+ Coverage   74.22%   74.68%   +0.45%     
==========================================
  Files         111      112       +1     
  Lines        2778     2824      +46     
==========================================
+ Hits         2062     2109      +47     
+ Misses        716      715       -1     
Impacted Files Coverage Δ
FFMpegCore/FFMpeg/FFMpeg.cs 67.17% <72.72%> (+0.32%) ⬆️
FFMpegCore/FFMpeg/Arguments/GifPaletteArgument.cs 100.00% <100.00%> (ø)
FFMpegCore/FFMpeg/Enums/FileExtension.cs 38.88% <100.00%> (+3.59%) ⬆️
FFMpegCore/FFMpeg/FFMpegArgumentOptions.cs 85.00% <100.00%> (+0.25%) ⬆️
FFMpegCore/FFMpeg/SnapshotArgumentBuilder.cs 80.39% <100.00%> (+26.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rosenbjerg
Copy link
Owner

Hi @rpaschoal,
This looks great, thanks for the contribution to this project!

@rosenbjerg rosenbjerg merged commit 4cf7778 into rosenbjerg:main Mar 7, 2023
@rpaschoal
Copy link
Contributor Author

Thanks @rosenbjerg , happy to contribute 🙂

Do you have an idea of when these changes might be going live in a new version over Nuget?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants