Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expected bytes error and import cleanup #400

Merged
merged 2 commits into from
Aug 16, 2022

Conversation

juntyr
Copy link
Member

@juntyr juntyr commented Aug 16, 2022

This cleanup PR includes

  • a small change to the error message for the unexpected bytes error to print the bytesrting with base64, since that's how it shows up in the ron
  • reformatting of all import statements (using the unstable imports_granularity = "Crate" and group_imports = "StdExternalCrate" options)

* [ ] I've included my change in CHANGELOG.md

@codecov-commenter
Copy link

Codecov Report

Merging #400 (6039cec) into master (4089034) will decrease coverage by 6.24%.
The diff coverage is 47.36%.

@@            Coverage Diff             @@
##           master     #400      +/-   ##
==========================================
- Coverage   86.55%   80.31%   -6.25%     
==========================================
  Files          49       49              
  Lines        5803     6247     +444     
==========================================
- Hits         5023     5017       -6     
- Misses        780     1230     +450     
Impacted Files Coverage Δ
src/de/mod.rs 74.46% <ø> (ø)
src/de/value.rs 75.88% <0.00%> (-11.53%) ⬇️
src/options.rs 45.23% <ø> (-14.77%) ⬇️
src/ser/mod.rs 78.05% <ø> (-17.35%) ⬇️
src/ser/tests.rs 82.30% <0.00%> (-17.70%) ⬇️
src/value.rs 53.51% <0.00%> (-13.54%) ⬇️
tests/147_empty_sets_serialisation.rs 86.00% <0.00%> (-14.00%) ⬇️
tests/250_variant_newtypes.rs 94.36% <ø> (-5.64%) ⬇️
tests/depth_limit.rs 84.84% <0.00%> (-15.16%) ⬇️
tests/extensions.rs 78.37% <0.00%> (-21.63%) ⬇️
... and 29 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@juntyr
Copy link
Member Author

juntyr commented Aug 16, 2022

The codecov changes seem to be spurious since they only affect use statements.

@juntyr juntyr merged commit 75ac75e into ron-rs:master Aug 16, 2022
@juntyr juntyr deleted the expected-bytes-error branch August 16, 2022 18:13
juntyr added a commit to juntyr/ron that referenced this pull request Aug 15, 2023
* Format expected bytes error with base64 as in ron

* Reformat imports to be consistent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants