Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop panic when deduplicating releases #2067

Merged
merged 3 commits into from
Mar 10, 2022
Merged

Stop panic when deduplicating releases #2067

merged 3 commits into from
Mar 10, 2022

Conversation

Sajfer
Copy link
Contributor

@Sajfer Sajfer commented Jan 26, 2022

Stops panic when deduplicating releases, and only add release to deduplicated list if the release is in the selectedIds.

Added two testcases for the two issues that mention this problem.

Fixes #2062
Fixes #2065

Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot for fixing it @Sajfer!

@mumoshu mumoshu merged commit b1928e5 into roboll:master Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants