Fix various golangci-lint errors #2059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mumoshu
approved these changes
Feb 12, 2022
mumoshu
changed the title
w33dw0r7d
pushed a commit
to w33dw0r7d/helmfile
that referenced
this pull request
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, sorry for the huge MR.
Fixes golangci-lint errors exept for the error shown below:
Not sure how to solve this warnings. Suggestions would be appreciated.
$ golangci-lint run -E scopelint WARN [runner] The linter 'scopelint' is deprecated (since v1.39.0) due to: The repository of the linter has been deprecated by the owner. Replaced by exportloopref. pkg/state/create.go:310:5: SA9001: defers in this range loop won't run unless the channel gets closed (staticcheck) defer func() { ^ pkg/state/state.go:1083:6: SA9001: defers in this range loop won't run unless the channel gets closed (staticcheck) defer clean() ^Fixes #612