Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go-getter support to load base helmfiles #1998

Merged
merged 1 commit into from
Dec 21, 2021

Conversation

jonasrutishauser
Copy link
Contributor

Resolves #1193

@mumoshu
Copy link
Collaborator

mumoshu commented Dec 20, 2021

@jonasrutishauser Hi! This looks good. Just confirming, but how did you test this? Is this tested to work both with or without the use of go-getter style url in a bases entry?

@jonasrutishauser
Copy link
Contributor Author

I tested it manually (simple Helmfile) with and without go-getter style url in bases.
I even tested my tests by running them against the code without my changes.

Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see! Let's go ahead. Thanks for your contribution @jonasrutishauser ☺️

@mumoshu mumoshu merged commit 1986cb3 into roboll:master Dec 21, 2021
@mumoshu
Copy link
Collaborator

mumoshu commented Dec 21, 2021

@jonasrutishauser Ah, would you mind adding some documentation about this feature under https://github.com/roboll/helmfile/blob/master/docs/writing-helmfile.md#layering-state-files so that it's more discoverable? Thanks!

w33dw0r7d pushed a commit to w33dw0r7d/helmfile that referenced this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for referencing base helmfiles from a URL
2 participants