Add support for --insecure-skip-tls-verify flag on helm repo add command #1990
Conversation
README.md
Outdated
| # Advanced configuration: You can skip the verification of TLS for an https repo | ||
| - name: skipTls | ||
| url: https://ss.my-insecure-domain.com | ||
| skipTlsVerify: true |
There was a problem hiding this comment.
I prefer skipTLSVerify so that it is consistent with e.g. the existing tlsCACert. Let me do that change and merge this soon. Thank you for your patience and contribution!
|
Made the change everywhere to keep the code consistent. Should be ok |
…and. Co-authored-by: Yusuke Kuoka <[email protected]>
There was a problem hiding this comment.
LGTM. Thanks a lot for your contribution @BabisK!
I noticed something though- would you also need --insecure-skip-tls-verify on helm upgrade commands run by helmfile? Otherwise, you might end up failing on a chart download. Anyway, that's an another story. I'm merging this. Thanks again for your contribution!
|
@mumoshu if I'm not mistaken, helmfile only calls |
…and (roboll#1990) Parses a new field in repositories named `skipTLSVerify` and if set to `true`, it appends `--insecure-skip-tls-verify` in `helm repo add` command. This should be useful with internal self-signed repos, mitm proxies etc. Resolves roboll#1871
This PR fixes #1871. It parses a new field in repositories named
skipTlsVerifyand if set totrue, it appends--insecure-skip-tls-verifyinhelm repo addcommand.This should be useful with internal self-signed repos, mitm proxies etc.