Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pass-credentials to repo #1899

Merged
merged 1 commit into from
Jul 1, 2021
Merged

feat: pass-credentials to repo #1899

merged 1 commit into from
Jul 1, 2021

Conversation

ameddin73
Copy link
Contributor

This adds the ability to include the --pass-credentials flag to the helm add repo command by:

  • Adding repo.passCredentials to the helmfile yaml
  • Changing state, helmexec, and app to include RepositorySpec.PassCredentials

Resolves #1898

This adds the ability to include the --pass-credentials flag to the helm add repo command by:

- Adding repo.passCredentials to the helmfile yaml
- Changing state, helmexec, and app to include RepositorySpec.PassCredentials

Resolves roboll#1898
Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot for your contribution @ameddin73 ☺️

@mumoshu mumoshu merged commit 46b17e2 into roboll:master Jul 1, 2021
@ameddin73
Copy link
Contributor Author

Thanks! So happy to be a part of the project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helmfile should pass --args to "helm repo add"
3 participants