Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not fail on deps when chart is fetched by go-getter #1852

Merged
merged 1 commit into from
May 16, 2021

Conversation

mumoshu
Copy link
Collaborator

@mumoshu mumoshu commented May 16, 2021

The below now works:

releases:
- name: pinpoint
  chart: git::https://github.com/pinpoint-apm/pinpoint-kubernetes.git@pinpoint?ref=master

Trying to use chartify with go-getter on a broken chart might require you to add skipDeps: true, as originally intended in #1548:

repositories:
- name: linkerd
  url: https://helm.linkerd.io/stable

releases:
- name: linkerd
  chart: linkerd/linkerd2
  version: "2.8.1"
  skipDeps: true
  forceNamespace: linkerd
  values:
  - global:
      identityTrustAnchorsPEM: aaa
    identity:
      issuer:
        crtExpiry: foobar
        tls:
          crtPEM: foo
          keyPEM: bar

Fixes #1847

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chart with go-getter bugs with template cmd
1 participant