Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --skip-diff-on-install to helmfile diff #1841

Merged
merged 2 commits into from
May 16, 2021
Merged

Add --skip-diff-on-install to helmfile diff #1841

merged 2 commits into from
May 16, 2021

Conversation

dudicoco
Copy link
Contributor

@dudicoco dudicoco commented May 11, 2021 •
edited
Loading

closes #1840

@dudicoco
Copy link
Contributor Author

@mumoshu can you please advise on adding test cases? I've looked at app_test.go for reference but wasn't sure on how to adjust to fit diff_test.go.

@mumoshu
Copy link
Collaborator

mumoshu commented May 11, 2021

@dudicoco Thanks! Seems like you have to run make fmt in order to fix the code styling issues.

mumoshu
mumoshu approved these changes May 16, 2021
View reviewed changes
Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran make fmt myself and this LGTM now. Thanks for your contribution @dudicoco ☺️

@mumoshu mumoshu merged commit 92ba347 into roboll:master May 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mumoshu mumoshu mumoshu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add --skip-diff-on-install to helmfile diff
2 participants
@dudicoco @mumoshu