-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate to @luca/esbuild-deno-loader #1881
Closed
NathanFlurry
wants to merge
1
commit into
feat_add_build_script_for_direct_esbuild_testing
from
chore_migrate_to_luca/esbuild-deno-loader
Closed
chore: migrate to @luca/esbuild-deno-loader #1881
NathanFlurry
wants to merge
1
commit into
feat_add_build_script_for_direct_esbuild_testing
from
chore_migrate_to_luca/esbuild-deno-loader
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 18, 2025
Deploying rivet with
|
Latest commit: |
b6fc75d
|
Status: | ✅ Deploy successful! |
Preview URL: | https://6570f03f.rivet.pages.dev |
Branch Preview URL: | https://chore-migrate-to-luca-esbuil.rivet.pages.dev |
jog1t
approved these changes
Jan 18, 2025
5ca005d
to
3ba9d53
Compare
8ff3f4e
to
2cde66e
Compare
This was referenced Jan 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Migrates from a local development version of esbuild-deno-loader to the official @luca/esbuild-deno-loader package from JSR, updating import mappings in deno.jsonc.
- Replaced local path imports with JSR package
@luca/esbuild-deno-loader@^0.11.1
inpackages/toolchain/js-utils-embed/js/deno.jsonc
- Removed hardcoded local paths for
x/importmap
andx/importmap/_util.ts
that reference/Users/nathan/
- Found duplicate
noImplicitAny
compiler option that needs to be removed - Identified potential issue with vendor paths still referencing local development environment
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
3ba9d53
to
539e54e
Compare
2cde66e
to
36a2119
Compare
539e54e
to
4dfa094
Compare
36a2119
to
b6fc75d
Compare
This was referenced Jan 22, 2025
This was referenced Jan 22, 2025
Merge activity
|
Closed
4dfa094
to
47619e5
Compare
b6fc75d
to
e2a105a
Compare
NathanFlurry
added a commit
that referenced
this pull request
Jan 22, 2025
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes