Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate to @luca/esbuild-deno-loader #1881

Conversation

NathanFlurry
Copy link
Member

Changes

Copy link
Member Author

NathanFlurry commented Jan 18, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

cloudflare-workers-and-pages bot commented Jan 18, 2025

Deploying rivet with  Cloudflare Pages  Cloudflare Pages

Latest commit: b6fc75d
Status: ✅  Deploy successful!
Preview URL: https://6570f03f.rivet.pages.dev
Branch Preview URL: https://chore-migrate-to-luca-esbuil.rivet.pages.dev

View logs

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Migrates from a local development version of esbuild-deno-loader to the official @luca/esbuild-deno-loader package from JSR, updating import mappings in deno.jsonc.

  • Replaced local path imports with JSR package @luca/esbuild-deno-loader@^0.11.1 in packages/toolchain/js-utils-embed/js/deno.jsonc
  • Removed hardcoded local paths for x/importmap and x/importmap/_util.ts that reference /Users/nathan/
  • Found duplicate noImplicitAny compiler option that needs to be removed
  • Identified potential issue with vendor paths still referencing local development environment

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Contributor

graphite-app bot commented Jan 22, 2025

Merge activity

@NathanFlurry NathanFlurry mentioned this pull request Jan 22, 2025
@NathanFlurry NathanFlurry force-pushed the feat_add_build_script_for_direct_esbuild_testing branch from 4dfa094 to 47619e5 Compare January 22, 2025 16:18
@NathanFlurry NathanFlurry force-pushed the chore_migrate_to_luca/esbuild-deno-loader branch from b6fc75d to e2a105a Compare January 22, 2025 16:18
NathanFlurry added a commit that referenced this pull request Jan 22, 2025
<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

<!-- If there are frontend changes, please include screenshots. -->
Copy link

Deploying rivet-hub with  Cloudflare Pages  Cloudflare Pages

Latest commit: e2a105a
Status:⚡️  Build in progress...

View logs

@graphite-app graphite-app bot closed this Jan 22, 2025
@graphite-app graphite-app bot deleted the chore_migrate_to_luca/esbuild-deno-loader branch January 22, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants