Rework types calculation with locks #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ameyer-rigetti
force-pushed
the
152-performance-bug
branch
from
340098e to
fc045a1
Compare
ameyer-rigetti
force-pushed
the
152-performance-bug
branch
from
fc045a1 to
37c7446
Compare
|
Do you need to patch in VERSION.txt again? |
@erichulburd That's a good question. I left it off as it's more part of the release process to bump that (i.e. separate PR). I don't have any real qualms with doing it here though if we're certain we're going to release it right after this. |
|
@erichulburd I went ahead and bumped the version |
erichulburd
approved these changes
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reintroduces memoization for
Message.types()but now with thread locking.Closes #152